Improve bounds in Iterator API #24217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -207,8 +207,10 @@ pub trait Iterator { | |||
| /// both produce the same output. | |||
| #[inline] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| fn zip<U: Iterator>(self, other: U) -> Zip<Self, U> where Self: Sized { | |||
| Zip{a: self, b: other} | |||
| fn zip<U: Iterator>(self, other: U) -> Zip<Self, U::IntoIter> where | |||
There was a problem hiding this comment.
is the Iterator bound on U still necessary?
|
Looks good at first glance |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
This commit changes `Iterator`'s API by: * Generalizing bounds from `Iterator` to `IntoIterator` whenever possible, matching the semantics and ergonomics of `for` loops. * Tightens up a few method-level bounds so that you get an error earlier. For example, `rev` did not require `DoubleEndedIterator` even though the result is only an `Iterator` when the original iterator was double-ended. Closes rust-lang#23587 The bound-tightening is technically a: [breaking-change] but no code should break in practice. r? @alexcrichton cc @Kimundi
This commit changes `Iterator`'s API by: * Generalizing bounds from `Iterator` to `IntoIterator` whenever possible, matching the semantics and ergonomics of `for` loops. * Tightens up a few method-level bounds so that you get an error earlier. For example, `rev` did not require `DoubleEndedIterator` even though the result is only an `Iterator` when the original iterator was double-ended. Closes rust-lang#23587 The bound-tightening is technically a: [breaking-change] but no code should break in practice.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
Iterator's API by:IteratortoIntoIteratorwheneverpossible, matching the semantics and ergonomics of
forloops.earlier. For example,
revdid not requireDoubleEndedIteratoreventhough the result is only an
Iteratorwhen the original iterator wasdouble-ended.
Closes #23587
The bound-tightening is technically a:
[breaking-change]
but no code should break in practice.
r? @alexcrichton
cc @Kimundi